Change signature of get_many_mut APIs
#562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urgau
force-pushed
the
new-get-many-mut
branch
from
c1be149 to
b6d96ca
Compare
cuviper
reviewed
Sep 25, 2024
Urgau
force-pushed
the
new-get-many-mut
branch
3 times, most recently
from
5f59023 to
1ce75c1
Compare
Urgau
commented
Sep 27, 2024
Urgau
force-pushed
the
new-get-many-mut
branch
2 times, most recently
from
b582436 to
6b28835
Compare
Amanieu
reviewed
Sep 30, 2024
Urgau
force-pushed
the
new-get-many-mut
branch
from
6b28835 to
e78ea1f
Compare
Amanieu
reviewed
Sep 30, 2024
Urgau
force-pushed
the
new-get-many-mut
branch
from
e78ea1f to
c1ee6ee
Compare
Amanieu
reviewed
Oct 1, 2024
by 1) panicking on overlapping keys and 2) returning an array of Option rather than an Option of array.
Urgau
force-pushed
the
new-get-many-mut
branch
from
c1ee6ee to
d50e3b2
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the signature and contract of the
get_many_mutAPIs byThis was asked by T-libs-api in rust-lang/rust#97601 (comment) regarding the corresponding std
HashMapfunctions.