Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(config): improve docs of Config::get_str/Config::get_bytes #1102

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

RobWalt
Copy link
Contributor

@RobWalt RobWalt commented Nov 27, 2024

We noticed that the docs around config are not as helpful yet as they could be. Newer rust users tend to assume that using get_str wouldn't be as hard to use and that it instead would work the same way as the other getters. This commit:

  • Adds a link to snapshot method documentation to provide additional guidance for newer Rust users
  • Extends the error explanation with a vague reason to enhance understanding of the current behavior

We noticed that the docs around config are not as helpful yet as they
could be. Newer rust users tend to assume that using `get_str` wouldn't
be as hard to use and that it instead would work the same way as the other
getters. This commit:

- Adds a link to `snapshot` method documentation to provide additional
  guidance for newer Rust users.
- Extends the error explanation with a vague reason to enhance
  understanding of the current behavior.

Co-authored-by: gytic <[email protected]>
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ehuss ehuss added this pull request to the merge queue Nov 27, 2024
Merged via the queue into rust-lang:master with commit 9b18397 Nov 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants