feat: add method to set no_default_c/cxx_flags #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chiichen
changed the title
|
Corresponding bad case issue : Chiichen/libvnc-rs#1 |
| @@ -420,6 +424,18 @@ impl Config { | |||
| self | |||
| } | |||
|
|
|||
| /// Disables the generation of default compiler cxx flags. The default compiler flags may cause conflicts in some cross compiling scenarios. | |||
There was a problem hiding this comment.
You've mixed up the docstrings.
Anyways, there must be a cleaner way without the duplication. What if the same applies for other language targets down the line (Fortran, ASM)
There was a problem hiding this comment.
What's the meaning of cleaner way without the duplication. I think it's necessary to clear the default flags by languages instead of simply cleaning them for all the language targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a set of methods to implement something similar to
no_default_flagsin thecccrate. Issue here #198