Honor no_default_flags setting
#190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: `init_c_cfg` permits the user to set a `cc::Build` configuration. The setting for `no_default_flags` is always overridden by `uses_android_sdk`. This prevents a user from building with `no_default_flags = true`. Solution: Do not override `no_default_flags` value. In the event `uses_android_sdk` returns true, continue to set `no_default_flags` to true. Note that `no_default_flags` defaults to false. Issue: rust-lang#188
tgross35
added
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
init_c_cfgpermits the user to set acc::Buildconfiguration. The setting forno_default_flagsis always overridden byuses_android_sdk. This prevents a user from building withno_default_flags = true.Solution: Do not override
no_default_flagsvalue. In the eventuses_android_sdkreturns true, continue to setno_default_flagsto true. Note thatno_default_flagsdefaults to false.Issue: #188