-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for --package and virtual manifest #3385
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(rust_highfive has picked a reviewer for you, use r? to override) |
matklad
force-pushed
the
package-test
branch
from
December 12, 2016 13:05
ef5d03a
to
23faf5c
Compare
@bors: r+ Thanks! |
📌 Commit 23faf5c has been approved by |
⌛ Testing commit 23faf5c with merge 8f8bead... |
💔 Test failed - status-appveyor |
@bors: retry
…On Mon, Dec 12, 2016 at 4:51 PM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang-libs/cargo/build/1.0.566>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3385 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95PJaW2I9MGOYNMAsnF2NT4KgzNYJks5rHev3gaJpZM4LKhS9>
.
|
⌛ Testing commit 23faf5c with merge 6b818f4... |
💔 Test failed - status-appveyor |
@bors: retry
…On Tue, Dec 13, 2016 at 12:52 PM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang-libs/cargo/build/1.0.580>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3385 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95O2of_pYLGC2Go5jHQ1yptASJv7fks5rHwV4gaJpZM4LKhS9>
.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3194
The issue was actually fixed by #3221 (thanks @euclio !), so let's just add a test (a copy of
virtual_works
basically).