Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for --package and virtual manifest #3385

Merged
merged 1 commit into from
Dec 14, 2016

Conversation

matklad
Copy link
Member

@matklad matklad commented Dec 12, 2016

closes #3194

The issue was actually fixed by #3221 (thanks @euclio !), so let's just add a test (a copy of virtual_works basically).

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Dec 12, 2016

📌 Commit 23faf5c has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Dec 13, 2016

⌛ Testing commit 23faf5c with merge 8f8bead...

@bors
Copy link
Contributor

bors commented Dec 13, 2016

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member

alexcrichton commented Dec 13, 2016 via email

@bors
Copy link
Contributor

bors commented Dec 13, 2016

⌛ Testing commit 23faf5c with merge 6b818f4...

@bors
Copy link
Contributor

bors commented Dec 13, 2016

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member

alexcrichton commented Dec 13, 2016 via email

@bors
Copy link
Contributor

bors commented Dec 13, 2016

⌛ Testing commit 23faf5c with merge 020df94...

bors added a commit that referenced this pull request Dec 13, 2016
Add test for --package and virtual manifest

closes #3194

The issue was actually fixed by #3221 (thanks @euclio !), so let's just add a test (a copy of `virtual_works` basically).
@bors
Copy link
Contributor

bors commented Dec 14, 2016

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 020df94 to master...

@bors bors merged commit 23faf5c into rust-lang:master Dec 14, 2016
@matklad matklad deleted the package-test branch January 18, 2017 10:19
@ehuss ehuss added this to the 1.15.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workspaces: Cargo commands with explicit package should work from the root of the workspace.
5 participants