Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(trim-paths): set env CARGO_TRIM_PATHS for build scripts #12900

Merged
merged 2 commits into from
Oct 31, 2023
Merged

feat(trim-paths): set env CARGO_TRIM_PATHS for build scripts #12900

merged 2 commits into from
Oct 31, 2023

Conversation

weihanglo
Copy link
Member

What does this PR try to resolve?

Set profile options as environment variable CARGO_TRIM_PATHS for build scripts.

As a follow up of #12625.

How should we test and review this PR?

Docs and test should be pretty straightforward.

Additional information

@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-build-scripts Area: build.rs scripts A-documenting-cargo-itself Area: Cargo's documentation A-profiles Area: profiles S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2023
@weihanglo weihanglo mentioned this pull request Oct 31, 2023
Open
8 tasks
@weihanglo weihanglo added Z-trim-paths Nightly: path sanitization A-environment-variables Area: environment variables labels Oct 31, 2023
@weihanglo
Copy link
Member Author

spurious network error seems like?

Error: failed to read index metadata for crate 'cargo-credential'

Caused by:
0: error sending request for url (https://index.crates.io/ca/rg/cargo-credential): connection error: connection reset
1: connection error: connection reset
2: connection reset

https://github.com/rust-lang/cargo/actions/runs/6706964313/job/18224456440?pr=12900#step:5:552

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2023
@weihanglo weihanglo force-pushed the trim-paths-build-script branch from 0c69592 to 32514c3 Compare October 31, 2023 15:25
epage
epage approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@epage epage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to r= me whether you make my suggestion or not.

@weihanglo weihanglo force-pushed the trim-paths-build-script branch from 32514c3 to 2915729 Compare October 31, 2023 16:01
@weihanglo
Copy link
Member Author

@bors r=epage

@bors
Copy link
Contributor

bors commented Oct 31, 2023

📌 Commit 2915729 has been approved by epage

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 31, 2023

⌛ Testing commit 2915729 with merge 05cce73...

@weihanglo weihanglo mentioned this pull request Oct 31, 2023
Merged
8 tasks
@bors
Copy link
Contributor

bors commented Oct 31, 2023

☀️ Test successful - checks-actions
Approved by: epage
Pushing 05cce73 to master...

@bors bors merged commit 05cce73 into rust-lang:master Oct 31, 2023
17 checks passed
@weihanglo weihanglo mentioned this pull request Oct 31, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 31, 2023
@bors
Auto merge of rust-lang#117462 - weihanglo:update-cargo, r=weihanglo
9d83ac2 
Update cargo

7 commits in 708383d620e183a9ece69b8fe930c411d83dee27..b4d18d4bd3db6d872892f6c87c51a02999b80802
2023-10-27 21:09:26 +0000 to 2023-10-31 18:19:10 +0000
- refactor(toml): Cleanup noticed on the way to rust-lang/cargo#12801 (rust-lang/cargo#12902)
- feat(trim-paths): set env `CARGO_TRIM_PATHS` for build scripts (rust-lang/cargo#12900)
- feat: implement RFC 3127 `-Ztrim-paths` (rust-lang/cargo#12625)
- docs: clarify config to use vendored source is printed to stdout (rust-lang/cargo#12893)
- Improve the margin calculation for the search command's UI (rust-lang/cargo#12890)
- Add new packages to [workspace.members] automatically (rust-lang/cargo#12779)
- refactor(toml): Decouple parsing from interning system (rust-lang/cargo#12881)

r? ghost
@ehuss ehuss added this to the 1.75.0 milestone Nov 6, 2023
@weihanglo weihanglo deleted the trim-paths-build-script branch November 28, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epage epage epage approved these changes

Assignees

@ehuss ehuss

Labels
A-build-scripts Area: build.rs scripts A-documenting-cargo-itself Area: Cargo's documentation A-environment-variables Area: environment variables A-profiles Area: profiles S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. Z-trim-paths Nightly: path sanitization
Projects
None yet
Milestone
1.75.0
Development

Successfully merging this pull request may close these issues.
5 participants
@weihanglo @rustbot @bors @epage @ehuss