Apply clippy::uninlined_format_args fixes

[nyurik]

This is the result of running clippy::uninlined_format_args lint. Currently the lint is in pedantic, but there are plans/hopes to move it to style.

How can I add this specific lint to the current build/CI tools, or is this not possible? It would be ideal not to make the lint as the default style and then end up with hundreds of changes in an unrelated PR due to CI requirements.

Locally, I ran this to generate the changes. Not ideal because it has produced a number of compilation errors.

rustup run nightly cargo clippy --fix --no-deps --allow-dirty -- -A clippy::all -W clippy::uninlined_format_args

Note that the MSRV must be at least 1.58 (which introduced inline format args)

[BurntSushi]

Currently the lint is in pedantic, but there are plans/hopes to move it to style.

Where can I participate in this discussion of plans?

[workingjubilee]

Thank you for your efforts. My apologies for it being so long to get around to this PR: this crate is fairly direly under-maintained. For that reason, currently this crate does not run clippy in CI, nor do I believe there is an intention to, as adding additional CI checks on getting code in is not what we want to be doing unless those are strictly necessary for functionality.

Normally I am inclined to approve a modest beautification PR like this, but I do not believe all of these changes are equally beautifying. Some make the code harder to read, by changing things so they are no longer read in a left-to-right manner, or in general complicating the code's overall style so that some of the results are surprising. If you wish to make additional changes to remove the diffs I have noted, or to improve the formatting code further until the concerns I have are eliminated, then I believe we could accept this. Otherwise, I will probably close this when I next make a pass over the PRs for this crate.

[nyurik]

thx for great feedback, agree, will fix!

[nyurik]

@workingjubilee I addressed your feedback, and added a few more similar inlinings.

To keep things cleaner, I think #539 should be merged first, possibly followed by #538

[github-actions]

Below is the size of a hello-world Rust program linked with libstd with backtrace.

Original binary size: 533976B
Updated binary size: 530480B
Difference: -3496B (-0.65%)

[nyurik]

@workingjubilee i rebased this PR to make sure it is up to date. Please review & merge unless there are some new issues. Thx!

[github-actions]

Code size changes for a hello-world Rust program linked with libstd with backtrace:

On platform windows-latest:

• Original binary size: 140,800 B
• Updated binary size: 138,752 B
• Difference: -2,048 B (-1.45%)