Skip to content

Commit

Permalink
Add -Cforce-frame-pointers to make the PDBALTPATH test case non-flaky…
Browse files Browse the repository at this point in the history
… on i686-pc-windows-msvc
  • Loading branch information
michaelwoerister committed Feb 27, 2024
1 parent 17148e5 commit b3a2a03
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -112,13 +112,14 @@ jobs:

# Test that backtraces are still symbolicated if we don't embed an absolute
# path to the PDB file in the binary.
- run: |
cargo clean
cargo test
# Add -Cforce-frame-pointers for stability. The test otherwise fails
# non-deterministically on i686-pc-windows-msvc because the stack cannot be
# unwound reliably. This failure is not related to the feature being tested.
- run: cargo clean && cargo test
if: contains(matrix.rust, 'msvc')
name: "Test that backtraces are symbolicated without absolute PDB path"
env:
RUSTFLAGS: "-C link-arg=/PDBALTPATH:%_PDB%"
RUSTFLAGS: "-Clink-arg=/PDBALTPATH:%_PDB% -Cforce-frame-pointers"

# Test that including as a submodule will still work, both with and without
# the `backtrace` feature enabled.
Expand Down

0 comments on commit b3a2a03

Please sign in to comment.