Add rustfmt check to CI #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed as expected for the temporary commit. I'll rebase it away and this should be ready. |
lqd
force-pushed
the
rustfmt
branch
5 times, most recently
from
12942a3 to
70383b2
Compare
In particular this should speed up the slowest builder (windows), by avoiding all rust docs being installed by rustup. It will also speed up local installs ofc.
|
You're a wizard 🧙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
rustfmtstep to CI, and reformats everything to make it pass.Fixes #170
I've also removed some default rustup components, as they are currently unused and slow down CI and local toolchain installs, e.g. unpacking all the documentation.
(This also updates a CI action triggering deprecation warnings, but the other one the repo uses is also deprecated and triggers warnings).