Resolve link once instead of canonicalize

rust-lang-ci · Dec 16, 2023 · 0cba7c8 · 0cba7c8
1 parent b7eeb3c
commit 0cba7c8
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/src/tools/compiletest/src/header.rs b/src/tools/compiletest/src/header.rs
@@ -1,6 +1,5 @@
 use std::collections::HashSet;
 use std::env;
-use std::fs::canonicalize;
 use std::fs::File;
 use std::io::prelude::*;
 use std::io::BufReader;
@@ -812,9 +811,12 @@ fn expand_variables(mut value: String, config: &Config) -> String {
     }
 
     if value.contains(RUST_SRC_BASE) {
-        let src = config.sysroot_base.join("lib/rustlib/src/rust");
-        let canonical = canonicalize(&src).unwrap();
-        value = value.replace(RUST_SRC_BASE, &canonical.to_string_lossy());
+        let src_base = config
+            .sysroot_base
+            .join("lib/rustlib/src/rust")
+            .read_link()
+            .expect("lib/rustlib/src/rust in target is a symlink to checkout root");
+        value = value.replace(RUST_SRC_BASE, &src_base.to_string_lossy());
     }
 
     value

diff --git a/src/tools/compiletest/src/runtest.rs b/src/tools/compiletest/src/runtest.rs
@@ -4222,8 +4222,12 @@ impl<'test> TestCx<'test> {
         normalize_path(parent_build_dir, "$BUILD_DIR");
 
         // Real paths into the libstd/libcore
-        let rust_src_dir =
-            &self.config.sysroot_base.join("lib/rustlib/src/rust").canonicalize().unwrap();
+        let rust_src_dir = &self
+            .config
+            .sysroot_base
+            .join("lib/rustlib/src/rust")
+            .read_link()
+            .expect("lib/rustlib/src/rust in target is a symlink to checkout root");
         normalize_path(&rust_src_dir.join("library"), "$SRC_DIR_REAL");
 
         if json {