Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a request to STM32H747I-DISCO bsc #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BigPapa314
Copy link

@BigPapa314 BigPapa314 commented Sep 21, 2020

Thanks for submitting!

Category

Is this PR a:

  • New Not Yet Awesome item?
  • A WIP project addressing an open item?
  • Removing a Not Yet Awesome item?

New Not Yet Awesome item checklist

  • Is the request clearly stated, linking to relevant documentation, such as a whitepaper, protocol definition, datasheet, etc.?
  • Are the "Success Criteria" defined?
  • Is this request possible using today's Rust (not blocked by LLVM impl, rustc impl, etc.)?
  • Is this request broken into reasonable work packages, such as "Create HAL for XYZ chip", not "support all boards from ABC vendor"?

WIP Project checklist

  • Is there a link to the source project on GitHub/GitLab/etc?
  • Is the project open source?
  • Is it clear if contributions are welcome?
  • Is the project relevant to the TODO item it addresses?
  • Is the project more than just an empty repo or a placeholder (e.g. just a "hello world" bin.rs/lib.rs)?

Remove an item checklist

  • Has the project that fixes the item been mentioned in the PR?
  • Does the project address the original request fully?
  • Has the crate that addresses the request has been added to the Awesome Embedded Rust list?
  • Has the crate has been published on crates.io (or somewhere else where other people can consume it)?

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @therealprof (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Sep 21, 2020
@hargoniX
Copy link
Member

The biggest blocker for this is, that as of now a good architecture for a "Board Support Crate" is not clearly defined, it has been brought up in a wg meeting recently (https://github.com/rust-embedded/wg/blob/master/minutes/2020-09-15.md) but the wg did not really come to a conclusion on what to do regarding this.

Hence IMHO a much better project would be to generalize this into a porject that sets a clear standard for how a BSP crate should look like, including for example a reference implementation for this board (and possibly others). If the wg or someone else starts building a clear guideline and meanwhile people work on this project in parallel and it turns out the design ideas behind the projects and the BSP ideas of the wg conflict you'll just end up with a project to rewrite (or two styles to merge), instead it would be better if we could bundle efforts for this early on since a "BSP standard" is basically non existing at this point.

@therealprof
Copy link
Contributor

Funny enough all references BSPs were written by me and yet I don't think they're even good examples for what a BSP should look like because they offer very little abstraction over board specific details and mostly contain examples.

In general the WG doesn't maintain specific device or even vendor specific code. While you're certainly welcome to open an item here, the chances of someone picking up your specific request are rather low. An approach with a higher chance of success might be to look for collaborators on the https://app.element.io/#/room/#stm32-rs:matrix.org to start one.

@BigPapa314
Copy link
Author

Hi Guys,

super to hear from you that fast. As you can see in my stats I'm new to the open source family. I'm interested in learning embedded architecture the Rusty way. So i thought building this crates on my own. Sadly I couldn't find a way of synchronizing my work with you guys, so i followed the contribution guide.

I've one of these STM32H747I-DISCO laying arround and am ready to start some experience. I think it's very interesting building a general layout of an BSP. Where might I get in touch with you all to discuss and maybe present some examples how to layout a BSP. (or BSC?)

@therealprof
Copy link
Contributor

@BigPapa314 You can find us live on Matrix/Element.io https://matrix.to/#/#rust-embedded:matrix.org.

More information about the working group can be found on https://github.com/rust-embedded/wg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants