fix: Update MSRV in Cargo.toml #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes rust-embedded#43 The MSRV was bumped in rust-embedded#42 but missed the `package.rust-version` metadata.
eldruin
reviewed
Oct 27, 2023
|
The unreleased section already mentions the MSRV bump. So I thought it was redundant.
https://github.com/rust-embedded/nb/blob/74606d1335c22c6bb4dbfda7690613fac45d0e3d/CHANGELOG.md?plain=1#L8-L11
What would you like to see as an entry?
…On October 27, 2023 10:34:45 AM GMT+02:00, Diego Barrios Romero ***@***.***> wrote:
@eldruin commented on this pull request.
Sorry, could you also add an entry to the changelog about this fix?
--
Reply to this email directly or view it on GitHub:
#44 (review)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
|
Ah, sorry I missed that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43
The MSRV was bumped in #42 but missed the
package.rust-versionmetadata.