Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a note regarding target dir location #520

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Add a note regarding target dir location #520

merged 2 commits into from
Mar 30, 2023

Conversation

arr-ee
Copy link
Contributor

@arr-ee arr-ee commented Mar 28, 2023

Closes #270, #495, #511.

Shout out to @mike2ykme for the original PR, not sure if I should mess with commit metadata to add credit.

@arr-ee arr-ee requested a review from a team as a code owner March 28, 2023 19:33
@arr-ee arr-ee mentioned this pull request Mar 28, 2023
Closed
eldruin
eldruin reviewed Mar 29, 2023
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!
Could you add a similar note to the f3 book as well?

@mike2ykme
Copy link

Hey @arr-ee i really appreciate you and everyone else on this. I’m super excited that something I mentioned is being handled.

@arr-ee
Copy link
Contributor Author

arr-ee commented Mar 29, 2023

@eldruin done

@mike2ykme <3

eldruin
eldruin approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!
bors r+

@bors
Copy link
Contributor

bors bot commented Mar 30, 2023

Build succeeded:

@bors bors bot merged commit 14d9b6e into rust-embedded:master Mar 30, 2023
This was referenced Mar 30, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arr-ee @mike2ykme @eldruin