Add Writer and ToSmolStr #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any chance of getting this added? It's such a waste to allocate a short string for formatting just to immediately convert it to an inline string. |
|
Actually, though github says it's fine, I do need to update it to 0.2. Will do that today. |
Veykril
reviewed
May 18, 2023
Veykril
approved these changes
Jan 11, 2024
|
Github closed this automatically when I pushed the refreshed branch. Should be good to go now, though. |
|
I went ahead and discarded the other cleanup changes, focusing on the actual feature, could open a new PR for those next. |
|
Feel free to open another PR for those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a
fmt::WriteWriter that will try not to allocate immediately, a trait similar toToStringthat makes use of the Writer, and a macroformat_smolstr!()that is similar toformat!().Cannot use specialization with
ToSmolStr, sadly, asToStringdoes.