ci: add generate log files and upload to S3 bucket #1194
+208
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sky1122
force-pushed
the
ci-e2e-testing
branch
from
d329684 to
099c8b1
Compare
sky1122
force-pushed
the
ci-e2e-testing
branch
2 times, most recently
from
3d47915 to
c44fe8f
Compare
.github/workflows/e2e-macos.yaml
Outdated
| with: | ||
| role-to-assume: ${{ secrets.ROLE }} | ||
| role-session-name: credhelper-test | ||
| aws-region: ${{ secrets.REGION }} | ||
| aws-region: ${{ secrets.REGION }} |
There was a problem hiding this comment.
nit: here and a few other places appears to be some trailing whitespace being appended to aws-region line.
There was a problem hiding this comment.
make sense. I add new commands in makefile and only let push event and nightly runs to generate the test report.
There was a problem hiding this comment.
For merges to mainline, I summarize two conditions. If there are more conditions, please let me know.
if [ "${{ github.event_name }}" == "push" ] && [ "${{ github.ref }}" == "refs/heads/main" ] ||
[ "${{ github.event_name }}" == "pull_request" ] && [ "${{ github.base_ref }}" == "main" ]; then
379dcc7 to
d197701
Compare
sky1122
requested review from
austinvazquez
and removed request for
austinvazquez
Signed-off-by: Jingwei Wang <[email protected]> fix Amazon Linux if condition Signed-off-by: Jingwei Wang <[email protected]> ci: only merges to mainline and nightly runs will generate log reports Signed-off-by: Jingwei Wang <[email protected]> Squashed commit message for the first 10 commits Signed-off-by: Jingwei Wang <[email protected]> fix minor errors Signed-off-by: Jingwei Wang <[email protected]> fix minor errors Signed-off-by: Jingwei Wang <[email protected]> fix minor errors Signed-off-by: Jingwei Wang <[email protected]> fix minor errors Signed-off-by: Jingwei Wang <[email protected]> fix minor errors Signed-off-by: Jingwei Wang <[email protected]>
Signed-off-by: Jingwei Wang <[email protected]>
sky1122
force-pushed
the
ci-e2e-testing
branch
from
d197701 to
d274fe8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add upload to S3 bucket
generate test log report while running the e2e testing
Makefile
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.