Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release): fix MSI release build rootfs path #1009

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

pendo324
Copy link
Member

@pendo324 pendo324 commented Jul 2, 2024

Issue #, if available:

  • MSI release builds are broken, as seen in this automated run
    • Debugged by looking at the lima stderr logs and found:
    {"level":"fatal","msg":"failed to download \"file://C:/actions-runner/_work/finch/finch/_output/os/finch-rootfs-production-amd64-1719439880.tar.gz\": open C:/actions-runner/_work/finch/finch/_output/os/finch-rootfs-production-amd64-1719439880.tar.gz: The system cannot find the path specified.","time":"2024-07-02T19:14:36Z"}
    

Description of changes:

  • This regression occurred because FINCH_ROOTFS_LOCATION_ROOT was removed from the Makefile during recent refactoring. FINCH_ROOTFS_LOCATION_ROOT was used to override the path of the rootfs file used at runtime by Lima. Removing it means that release builds, which are installed to different locations than dev builds, will not function. This PR makes it so Windows follows the macOS Makefile variable name (FINCH_OS_IMAGE_LOCATION_ROOT), as seen in ci(release): fix release build generation #1007

Testing done:

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pendo324 pendo324 added bug Something isn't working github_actions Pull requests that update GitHub Actions code windows Anything Windows specific labels Jul 2, 2024
@pendo324 pendo324 requested a review from austinvazquez July 2, 2024 19:28
@pendo324 pendo324 self-assigned this Jul 2, 2024
@pendo324 pendo324 requested a review from a team as a code owner July 2, 2024 19:28
austinvazquez
austinvazquez previously approved these changes Jul 2, 2024
Signed-off-by: Justin Alvarez <[email protected]>
pendo324 added 3 commits July 2, 2024 15:39
Signed-off-by: Justin Alvarez <[email protected]>
Signed-off-by: Justin Alvarez <[email protected]>
…n different branches/tags

Signed-off-by: Justin Alvarez <[email protected]>
@pendo324
Copy link
Member Author

pendo324 commented Jul 2, 2024

Confirmed Finch VM was able to start in the release workflow: https://github.com/runfinch/finch/actions/runs/9767086718/job/26961647512#step:13:56

Confirmed we can manually kick off release builds from different source tags using the ref_name input: https://github.com/runfinch/finch/actions/runs/9767146410/job/26961744190#step:9:19

(I cancelled both workflows so that we can use the resources to run from main instead of this branch)

PTAL again @austinvazquez

@pendo324 pendo324 requested a review from austinvazquez July 2, 2024 19:56
@austinvazquez austinvazquez merged commit 12b6934 into main Jul 2, 2024
42 of 44 checks passed
@austinvazquez austinvazquez deleted the fix-msi-release-build branch July 2, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code windows Anything Windows specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants