ci(release): fix MSI release build rootfs path #1009
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
FINCH_ROOTFS_LOCATION_ROOT
was removed from the Makefile during recent refactoring.FINCH_ROOTFS_LOCATION_ROOT
was used to override the path of the rootfs file used at runtime by Lima. Removing it means that release builds, which are installed to different locations than dev builds, will not function. This PR makes it so Windows follows the macOS Makefile variable name (FINCH_OS_IMAGE_LOCATION_ROOT
), as seen in ci(release): fix release build generation #1007Testing done:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.