chore: add longform boolean unit tests (#1186)

Signed-off-by: Arjun Raja Yogidas <[email protected]>
runfinch · Nov 25, 2024 · c3dc161 · c3dc161
1 parent e6ba6e8
commit c3dc161
Show file tree

Hide file tree

Showing 3 changed files with 75 additions and 1 deletion.
diff --git a/cmd/finch/nerdctl_darwin_test.go b/cmd/finch/nerdctl_darwin_test.go
@@ -1171,6 +1171,41 @@ func TestNerdctlCommand_run(t *testing.T) {
 				c.EXPECT().Run()
 			},
 		},
+		{
+			name:    "with long-form boolean flags",
+			cmdName: "run",
+			fc:      &config.Finch{},
+			args: []string{
+				"--env", "ARG1=val1", "-p", "8080:8080",
+				"--name", "myContainer", "--interactive=true", "--detach", "--rm=true", "--init=false",
+				"--tty=true", "--debug-full=false", "--sig-proxy=0",
+				"--experimental=false", "--oom-kill-disable=false", "--read-only=false",
+				"--privileged=false", "alpine:latest", "env",
+			},
+			wantErr: nil,
+			mockSvc: func(
+				_ *testing.T,
+				lcc *mocks.NerdctlCmdCreator,
+				_ *mocks.CommandCreator,
+				ncsd *mocks.NerdctlCommandSystemDeps,
+				logger *mocks.Logger,
+				ctrl *gomock.Controller,
+				_ afero.Fs,
+			) {
+				getVMStatusC := mocks.NewCommand(ctrl)
+				lcc.EXPECT().CreateWithoutStdio("ls", "-f", "{{.Status}}", limaInstanceName).Return(getVMStatusC)
+				getVMStatusC.EXPECT().Output().Return([]byte("Running"), nil)
+				logger.EXPECT().Debugf("Status of virtual machine: %s", "Running")
+				AddEmptyEnvLookUps(ncsd)
+				c := mocks.NewCommand(ctrl)
+				lcc.EXPECT().Create("shell", limaInstanceName, "sudo", "-E", nerdctlCmdName, "container", "run",
+					"-p", "8080:8080", "--name", "myContainer", "--interactive=true", "--detach", "--rm=true",
+					"--init=false", "--tty=true", "--debug-full", "false", "--sig-proxy=0",
+					"--experimental", "false", "--oom-kill-disable=false", "--read-only=false",
+					"--privileged=false", "-e", "ARG1=val1", "alpine:latest", "env").Return(c)
+				c.EXPECT().Run()
+			},
+		},
 	}
 
 	for _, tc := range testCases {

diff --git a/cmd/finch/nerdctl_native.go b/cmd/finch/nerdctl_native.go
@@ -93,7 +93,6 @@ func (nc *nerdctlCommand) run(cmdName string, args []string) error {
 	}
 
 	return nc.ncc.Create(cmdArgs...).Run()
-
 }
 
 var osAliasMap = map[string]string{}

diff --git a/cmd/finch/nerdctl_windows_test.go b/cmd/finch/nerdctl_windows_test.go
@@ -769,6 +769,46 @@ func TestNerdctlCommand_run(t *testing.T) {
 				c.EXPECT().Run()
 			},
 		},
+		{
+			name:    "with long-form boolean flags",
+			cmdName: "run",
+			fc:      &config.Finch{},
+			args: []string{
+				"--env", "ARG1=val1", "-p", "8080:8080",
+				"--name", "myContainer", "--interactive=true", "--detach", "--rm=true", "--init=false",
+				"--tty=true", "--debug-full=false", "--sig-proxy=0",
+				"--experimental=false", "--oom-kill-disable=false", "--read-only=false",
+				"--privileged=false", "alpine:latest", "env",
+			},
+			wantErr: nil,
+			mockSvc: func(
+				_ *testing.T,
+				_ *mocks.CommandCreator,
+				ncc *mocks.NerdctlCmdCreator,
+				_ *mocks.Command,
+				ncsd *mocks.NerdctlCommandSystemDeps,
+				logger *mocks.Logger,
+				ctrl *gomock.Controller,
+				_ afero.Fs,
+			) {
+				getVMStatusC := mocks.NewCommand(ctrl)
+				ncc.EXPECT().CreateWithoutStdio("ls", "-f", "{{.Status}}", limaInstanceName).Return(getVMStatusC)
+				getVMStatusC.EXPECT().Output().Return([]byte("Running"), nil)
+				logger.EXPECT().Debugf("Status of virtual machine: %s", "Running")
+				AddEmptyEnvLookUps(ncsd)
+				ncsd.EXPECT().GetWd().Return("C:\\workdir", nil)
+				ncsd.EXPECT().FilePathAbs("C:\\workdir").Return("C:\\workdir", nil)
+				ncsd.EXPECT().FilePathJoin(string(filepath.Separator), "mnt", "c", "workdir").Return(augmentedPath)
+				ncsd.EXPECT().FilePathToSlash(augmentedPath).Return(wslPath)
+				c := mocks.NewCommand(ctrl)
+				ncc.EXPECT().Create("shell", "--workdir", wslPath, limaInstanceName, "sudo", "-E", nerdctlCmdName, "container", "run",
+					"-p", "8080:8080", "--name", "myContainer", "--interactive=true", "--detach", "--rm=true",
+					"--init=false", "--tty=true", "--debug-full", "false", "--sig-proxy=0",
+					"--experimental", "false", "--oom-kill-disable=false", "--read-only=false",
+					"--privileged=false", "-e", "ARG1=val1", "alpine:latest", "env").Return(c)
+				c.EXPECT().Run()
+			},
+		},
 	}
 
 	for _, tc := range testCases {
-Original file line number
+Diff line change
@@ Expand Up @@
     	}
     	return nc.ncc.Create(cmdArgs...).Run()
     }
     var osAliasMap = map[string]string{}
@@ Expand Down @@