Better documentation creation ref #648 #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks very nice! |
udoprog
reviewed
Mar 13, 2024
| @@ -1,5 +1,5 @@ | |||
| {{#> layout}} | |||
| <h3 class="title">Enum {{literal module}}::<span class="enum">{{name}}</span></h3> | |||
| <div class="title-wrapper"><h3 class="title">Enum {{literal module}}::<span class="enum">{{name}}</span></h3><a class="overview" href="{{literal root_index}}">Overview</a></div> | |||
There was a problem hiding this comment.
Could you post a screenshot of how the overview links is expected to render with title-wrapper?
There was a problem hiding this comment.
It look like this right now. I really tried to find a better place, but failed 😅
But the original rust documentation is also using that place, but for another feature.....
|
Closes #648 when merged |
|
Thanks for putting this together! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I implemented the enhancements for the documentation generation #648 by myself.
Looking forward to get these improvements merged 😄
Right now I called the link back to the root overview just 'Overview', maybe you have a better name.
Please let me know if something if not as you like.
Thanks,
Robert