Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make function for formatting of Source Code public #652

Closed
wants to merge 5 commits into from

Conversation

Roba1993
Copy link
Contributor

No description provided.

The Formatter is needed for various interactions with a rune values. Therefore I need to be able to get a string as result out of the Formatter.

Why is this needed?
When receiving a generic rune::Value from the vm, this value can be a Result. To debug format the error result in rust, the formatter is now needed. Unfortunately the value can't be received out of the Formatter as of now.
@udoprog udoprog added the enhancement New feature or request label Oct 30, 2023
@udoprog
Copy link
Collaborator

udoprog commented Oct 30, 2023

Not that I oppose it, but any particular reason you want this public.

It will probably change a fair bit by next release.

@Roba1993
Copy link
Contributor Author

Within the exolynk platform the code should be automatically formatted while saving & testing. The code is inside the db, so formatting a file is not possible.

Roba1993 referenced this pull request Feb 22, 2024
* Create a public function for source code formatting.
* Add `use crate::alloc::String;`
* Make fmt module public
@Roba1993
Copy link
Contributor Author

Implemented by #79e81a0

@Roba1993 Roba1993 closed this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants