Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add mermaid config #4643

Merged
merged 6 commits into from
Jun 9, 2024
Merged

fix: add mermaid config #4643

merged 6 commits into from
Jun 9, 2024

Conversation

chenrui333
Copy link
Member

followup #4608

@chenrui333 chenrui333 requested review from a team as code owners June 9, 2024 22:56
@chenrui333 chenrui333 requested review from jamengual, nitrocode and X-Guardian and removed request for a team June 9, 2024 22:56
Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 force-pushed the fix-mermaid-diagram branch from 1d10005 to c193a77 Compare June 9, 2024 23:14
@github-actions github-actions bot added size/m and removed size/l labels Jun 9, 2024
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
@github-actions github-actions bot added docs Documentation github-actions size/l and removed size/m labels Jun 9, 2024
Signed-off-by: Rui Chen <[email protected]>
@chenrui333
Copy link
Member Author

some rendering issue with pnpm build

image

switching to npm build

Signed-off-by: Rui Chen <[email protected]>
@chenrui333
Copy link
Member Author

looks good now.
image

@chenrui333 chenrui333 merged commit 91ff643 into main Jun 9, 2024
27 checks passed
@chenrui333 chenrui333 deleted the fix-mermaid-diagram branch June 9, 2024 23:34
@X-Guardian
Copy link
Contributor

@chenrui333, looks like you missed removing pnpm-lock.yaml in this PR when you reverted back to npm.

terakoya76 pushed a commit to terakoya76/atlantis that referenced this pull request Dec 31, 2024
kvanzuijlen pushed a commit to kvanzuijlen/atlantis that referenced this pull request Jan 4, 2025
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: kvanzuijlen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants