Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: renovate dockerfile handling #4565

Merged
merged 3 commits into from
May 15, 2024

Conversation

erpel
Copy link
Contributor

@erpel erpel commented May 15, 2024

what

This is the fixes by @tiagomeireles in #4381. Rebased on main to resolve conflicts.
All credit goes to the original author, I'm just trying to help get it merged.

why

This broke in 6d3aef2 when it switched the defines from ENVs to ARGs.

tests

Manually tested on my fork of Atlantis.

references

closes #4381

@erpel erpel requested review from a team as code owners May 15, 2024 07:15
@erpel erpel requested review from jamengual, lukemassa and nitrocode and removed request for a team May 15, 2024 07:15
@github-actions github-actions bot added build Relating to how we build Atlantis github-actions labels May 15, 2024
@erpel erpel changed the title Rebased tiagos renovate fix fix: renovate dockerfile handling - Rebased tiagos renovate fix May 15, 2024
@chenrui333 chenrui333 changed the title fix: renovate dockerfile handling - Rebased tiagos renovate fix fix: renovate dockerfile handling May 15, 2024
@chenrui333 chenrui333 merged commit 00fcc64 into runatlantis:main May 15, 2024
28 checks passed
terakoya76 pushed a commit to terakoya76/atlantis that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Relating to how we build Atlantis github-actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants