fix: implement tests for gitlab client 409 Conflict handling #4548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jippi
requested review from
GenPage,
lukemassa and
X-Guardian
and removed request for
a team
jippi
force-pushed
the
add-tests-for-gitlab
branch
from
76c290f to
0b8be9d
Compare
jippi
commented
May 14, 2024
jippi
commented
May 14, 2024
chenrui333
approved these changes
May 19, 2024
|
lgtm merging. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
The follow-up to #4503 adding tests for the retry logic
Simply adding tests for the bug fix that's already been merged
why
Tests are good, and I promised!
tests
This is only testing
references