-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding support for bitbucket cloud webhook secrets #4275
base: main
Are you sure you want to change the base?
feat: adding support for bitbucket cloud webhook secrets #4275
Conversation
kindly get this change merged. we are in very much need for this feature. |
@almightyfoon, can you resolve the conflicts on this PR? |
Signed-off-by: Joshua Spork <[email protected]>
This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month. |
Gentle bump, would be nice to have this. |
Very little work needs to be done to get this merged, if anyone can pick it up and finish the changes we could get this merged. |
Sorry for the delay, real life got in the way. Working on clearing the failed tests. |
Signed-off-by: Josh Spork <[email protected]>
@almightyfoon do you have time to finish this? Thanks. |
what
Added support for Bitbucket Cloud Webhook secrets. Bitbucket added support in the cloud offering in October of 2023 Announcement
why
There is an open request for this #3909 and I'm also in need of this feature.
tests
I ran make test, the logic is the same as bitbucketserver.
Test results:
? github.com/runatlantis/atlantis [no test files]
ok github.com/runatlantis/atlantis/cmd 0.113s
ok github.com/runatlantis/atlantis/server (cached)
ok github.com/runatlantis/atlantis/server/controllers (cached)
ok github.com/runatlantis/atlantis/server/controllers/events (cached)
ok github.com/runatlantis/atlantis/server/controllers/templates (cached)
ok github.com/runatlantis/atlantis/server/controllers/websocket (cached)
ok github.com/runatlantis/atlantis/server/core/config (cached)
ok github.com/runatlantis/atlantis/server/core/config/raw (cached)
ok github.com/runatlantis/atlantis/server/core/config/valid (cached)
ok github.com/runatlantis/atlantis/server/core/db (cached)
ok github.com/runatlantis/atlantis/server/core/locking (cached)
ok github.com/runatlantis/atlantis/server/core/redis (cached)
ok github.com/runatlantis/atlantis/server/core/runtime (cached)
ok github.com/runatlantis/atlantis/server/core/runtime/cache (cached)
ok github.com/runatlantis/atlantis/server/core/runtime/common (cached)
ok github.com/runatlantis/atlantis/server/core/runtime/models (cached)
ok github.com/runatlantis/atlantis/server/core/runtime/policy (cached)
ok github.com/runatlantis/atlantis/server/core/terraform (cached)
ok github.com/runatlantis/atlantis/server/events (cached)
ok github.com/runatlantis/atlantis/server/events/command (cached)
ok github.com/runatlantis/atlantis/server/events/models (cached)
ok github.com/runatlantis/atlantis/server/events/terraform/ansi (cached)
ok github.com/runatlantis/atlantis/server/events/vcs (cached)
ok github.com/runatlantis/atlantis/server/events/vcs/bitbucketcloud (cached)
ok github.com/runatlantis/atlantis/server/events/vcs/bitbucketserver (cached)
ok github.com/runatlantis/atlantis/server/events/vcs/common (cached)
ok github.com/runatlantis/atlantis/server/events/webhooks (cached)
ok github.com/runatlantis/atlantis/server/jobs (cached)
ok github.com/runatlantis/atlantis/server/logging (cached)
ok github.com/runatlantis/atlantis/server/metrics (cached)
ok github.com/runatlantis/atlantis/server/recovery (cached)
? github.com/runatlantis/atlantis/testdrive [no test files]
ok github.com/runatlantis/atlantis/server/scheduled (cached)
ok github.com/runatlantis/atlantis/server/utils (cached)
references
Closes #3909