This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
json_entry_added_etc #500
Merged
json_entry_added_etc #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryjliu
reviewed
Sep 7, 2023
There was a problem hiding this comment.
@sangwongenip I just realized, neither hangeul nor hwp were added to library.json right? could we add that? thanks
Yep! |
Done! Test failure happens because 'olefile' package is not included in test_requirements.txt right now. I added it in another commit. |
|
thanks! |
jerryjliu
approved these changes
Sep 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Deleted 'hangeul' directory, whose contents are same with 'hwp'. Sorry for my mistake.
2.Added entry for extra info.
thanks!