This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Bagel loader Added #479
Merged
Bagel loader Added #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@logan-markewich TIA |
jerryjliu
reviewed
Aug 23, 2023
llama_hub/bagel/README.md
Outdated
| Here's an example usage of the BagelReader. | ||
|
|
||
| ```python | ||
| from llama_index import download_loader |
There was a problem hiding this comment.
nit: canonical is now from llama_hub.bagel.base import BagelReader (no need for download_loader)
There was a problem hiding this comment.
Changed in ReadMe..
Thanks
Done.. |
jerryjliu
approved these changes
Aug 23, 2023
|
got it.. fixed it.. sorry for the inconvenience. passes the tests. can you merge? |
|
@logan-markewich can you please look into it?? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added loader for BageDB
BagelDB vector store and reader already available at Llama Index.