Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Adding Azure speech, translate and CV tools #459

Merged
merged 6 commits into from
Aug 15, 2023

Conversation

ajhofmann
Copy link
Contributor

One question about this; adding the files to the data folder is nice for the demos, but we should make sure we aren't packaging the notebooks directory in our pip package, since the files are going to start making the download needlessly large.

@ajhofmann ajhofmann force-pushed the adam/azure-speech branch 2 times, most recently from f1607a0 to fa7c02a Compare August 11, 2023 14:53
@ajhofmann ajhofmann force-pushed the adam/azure-speech branch 2 times, most recently from a59468b to 86076da Compare August 11, 2023 16:42
@ajhofmann ajhofmann changed the title Adding Azure speech tools Adding Azure speech, translate and CV tools Aug 11, 2023
@jerryjliu
Copy link
Collaborator

One question about this; adding the files to the data folder is nice for the demos, but we should make sure we aren't packaging the notebooks directory in our pip package, since the files are going to start making the download needlessly large.

regarding that point could we upload to dropbox and just wget it?

@ajhofmann
Copy link
Contributor Author

One question about this; adding the files to the data folder is nice for the demos, but we should make sure we aren't packaging the notebooks directory in our pip package, since the files are going to start making the download needlessly large.

regarding that point could we upload to dropbox and just wget it?

For this file I think we can actually just download it from the source, will look into the other files in the data folder to see whats worth refactoring into dropbox.

@ajhofmann
Copy link
Contributor Author

ajhofmann commented Aug 14, 2023

azure_cv.mp4

CV demo, working on a demo video for the speech tools

@ajhofmann
Copy link
Contributor Author

https://drive.google.com/file/d/15iuxN_S47B4uc8Xh5scYUkWLiTQZYxks/view

@jerryjliu
Copy link
Collaborator

awesome!

Copy link
Collaborator

@jerryjliu jerryjliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

out of curiosity did you end up using dropbox?

@ajhofmann
Copy link
Contributor Author

looks good!

out of curiosity did you end up using dropbox?

Ended up just using a request to download the sample into a file directly from Azure where Microsoft was hosting in: https://github.com/emptycrown/llama-hub/pull/459/files#diff-a332a2ba989d2f7aafc1f20d1bc80c8ddbfda7f1417c1c2c92ab696993767b60R77-R80

I think maybe for something like the Shopify GraphQL schema dropbox could be useful, because its not being hosted anywhere public right now

@jerryjliu jerryjliu merged commit 4a66f19 into run-llama:main Aug 15, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants