Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

added a num parameter to the google_search #446

Merged
merged 2 commits into from
Aug 5, 2023

Conversation

rarisenpai
Copy link
Contributor

No description provided.

Copy link
Collaborator

@jerryjliu jerryjliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks mostly good to me, one minor nit

"""Initialize with parameters."""
self.key = key
self.engine = engine

def google_search(self, query: str):
def google_search(self, query: str, num: int=None):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: type as Optional[int] = None

@jerryjliu jerryjliu merged commit 613d2fa into run-llama:main Aug 5, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants