This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Added Semantic scholar reader #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is awesome! will review soon |
jerryjliu
reviewed
Aug 3, 2023
llama_hub/semantic_scholar/README.md
Outdated
| ServiceContext, | ||
| ) | ||
|
|
||
| s2reader = download_loader('SemanticScholarReader') |
There was a problem hiding this comment.
nit: you never import download_loader from llama_index
also recommended way now is from llama_hub.semantic_scholar.base import SemanticScholarReader (e.g. import as package)
There was a problem hiding this comment.
ahh thanks for pointing that out. I have included it here 20819ea
jerryjliu
approved these changes
Aug 3, 2023
Disiok
reviewed
Aug 3, 2023
llama_hub/semanticscholar/base.py
Outdated
| import logging | ||
| from llama_index.readers.base import BaseReader | ||
| from llama_index.readers.schema.base import Document | ||
| from semanticscholar import SemanticScholar |
There was a problem hiding this comment.
could you do the import from the class constructor or methods? The reason is that we want this to be lazily imported.
Take a look at other loader implementations as example!
There was a problem hiding this comment.
thank you for this suggestion! I have moved it here 977671c
jerryjliu
approved these changes
Aug 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module loads papers from semantic scholar search for which the user can question and get answers to. It is using the semanticscholar library to search and get results.
The user can define a broader search space, get the
Documentsloaded inllama_indexand then ask questions as demoed here -