This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Adding personal access token (PAT) authentication in Jira reader #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryjliu
reviewed
Aug 2, 2023
| def __init__(self, email: str, api_token: str, server_url: str) -> None: | ||
| def __init__( | ||
| self, | ||
| username: str = None, |
There was a problem hiding this comment.
nit: typing should be Optional[str] = None
|
bump @jinjintonic - can you fix the typing as mentioned above? |
|
They accept username and password but accept email and the api_token as well I would prefer to not give the option to use We can follow up with email, api_token, and add the personal access token as well (even not sure if it has a difference from api_token, I think not) |
|
Closing this PR now due to inactivity as well, a merge with the main will be necessary, feel free to reopen |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira reader uses misleading constructor argument name "api_token" but uses it as user password in basic auth. This change set renames email -> username, api_token -> password, as well as adds personal access token (PAT) option to be able to provide access to Jira instance without exposing user credentials.