Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds onUnmounting Hook #18

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Adds onUnmounting Hook #18

merged 2 commits into from
Jul 16, 2020

Conversation

tamb
Copy link
Contributor

@tamb tamb commented Sep 10, 2019

There needs to be an unmounting hook for solving issues like preserving form state and the other hooks need access to the root Node to avoid unnecessary lookups. There's also an example of how to preserve form state, though that doesn't need to be merged

@tamb tamb changed the title Adds Unmounting Hook Adds onUnmounting Hook Sep 10, 2019
@rumkin rumkin self-requested a review September 10, 2019 01:40
@rumkin rumkin merged commit 76c6d6f into rumkin:master Jul 16, 2020
@rumkin rumkin linked an issue Jul 25, 2020 that may be closed by this pull request
Research History manipulation influence and Form data #15
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumkin rumkin Awaiting requested review from rumkin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Research History manipulation influence and Form data
2 participants
@tamb @rumkin