Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing dependency on Bash on Windows platform #314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlexanderGolovlev
Copy link

Allows building the rules on Windows platform not using Bash shell.

@stakira
Copy link

stakira commented May 30, 2024

I support this fix. The bash issue is not only an extra step in setup, but can also cause dramatic confusions.

With WSL installed, the default bash.exe available is an entrance to WSL. Various proto library/compile rules will fail with very confusing message ''You seem to have passed an empty string as one of the arguments to protoc.exe. This is actually sort of hard to do. Congrats. Unfortunately it is not valid input so the program is going to die now." (see #308) The WSL bash.exe is located at at C:\Windows\System32, which is a path unreasonable to remove from PATH. The status quo is rather awkward and needs a fix.

@aaliddell
Copy link
Member

It looks like one of the test workspaces (special_characters) is repeatably failing under Windows with this change: https://buildkite.com/bazel/rules-proto-grpc-rules-proto-grpc/builds/2561#019003a6-0288-423a-8804-49253e72a823

Is there some escaping that is missing in passing the paths under the new code path?

@aaliddell aaliddell added the more-info-needed Further information is requested label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more-info-needed Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants