Disable exception catching for bad tokens

rughh · Oct 30, 2024 · c4bc489 · c4bc489
1 parent 60e0faf
commit c4bc489
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/lib/omni_auth/strategies/email.rb b/lib/omni_auth/strategies/email.rb
@@ -18,11 +18,9 @@ def callback_phase
         token = request.params['token']
         fail!(:authenticity_error) if token.blank?
 
-        begin
-          decoded_token = EmailAuthToken.decode(token)
-        rescue StandardError => e
-          fail!(:authenticity_error, e)
-        end
+        # Not catching the exception until this is more tested
+        # This way we'll get it reported in AppSignal for diagnosing
+        decoded_token = EmailAuthToken.decode(token)
 
         @email = decoded_token['iss'].to_s.downcase
         fail!(:authenticity_error) if @email.blank?