avm2: Do not ignore nulls in String.fromCharCode

ruffle-rs · Aug 18, 2023 · a44546a · a44546a
1 parent 7316f51
commit a44546a
Show file tree

Hide file tree

Showing 9 changed files with 0 additions and 12 deletions.
diff --git a/core/src/avm2/globals/string.rs b/core/src/avm2/globals/string.rs
@@ -189,10 +189,6 @@ fn from_char_code<'gc>(
     let mut out = WString::with_capacity(args.len(), false);
     for arg in args {
         let i = arg.coerce_to_u32(activation)? as u16;
-        if i == 0 {
-            // Ignore nulls.
-            continue;
-        }
         out.push(i);
     }
     Ok(AvmString::new(activation.context.gc_context, out).into())

diff --git a/tests/tests/swfs/from_avmplus/ecma3/GlobalObject/e15_1_2_5_3/test.toml b/tests/tests/swfs/from_avmplus/ecma3/GlobalObject/e15_1_2_5_3/test.toml
@@ -1,2 +1 @@
 num_ticks = 1
-known_failure = true
diff --git a/tests/tests/swfs/from_avmplus/ecma3/String/e15_5_3_2_3/test.toml b/tests/tests/swfs/from_avmplus/ecma3/String/e15_5_3_2_3/test.toml
@@ -1,2 +1 @@
 num_ticks = 1
-known_failure = true
diff --git a/tests/tests/swfs/from_avmplus/ecma3/String/e15_5_4_11_1/test.toml b/tests/tests/swfs/from_avmplus/ecma3/String/e15_5_4_11_1/test.toml
@@ -1,2 +1 @@
 num_ticks = 1
-known_failure = true
diff --git a/tests/tests/swfs/from_avmplus/ecma3/String/e15_5_4_12_1/test.toml b/tests/tests/swfs/from_avmplus/ecma3/String/e15_5_4_12_1/test.toml
@@ -1,2 +1 @@
 num_ticks = 1
-known_failure = true
diff --git a/tests/tests/swfs/from_avmplus/ecma3/String/e15_5_4_5_4/test.toml b/tests/tests/swfs/from_avmplus/ecma3/String/e15_5_4_5_4/test.toml
@@ -1,2 +1 @@
 num_ticks = 1
-known_failure = true
diff --git a/tests/tests/swfs/from_avmplus/ecma3/String/toLocaleLowerCase/test.toml b/tests/tests/swfs/from_avmplus/ecma3/String/toLocaleLowerCase/test.toml
@@ -1,2 +1 @@
 num_ticks = 1
-known_failure = true
diff --git a/tests/tests/swfs/from_avmplus/ecma3/String/toLocaleUpperCase5/test.toml b/tests/tests/swfs/from_avmplus/ecma3/String/toLocaleUpperCase5/test.toml
@@ -1,2 +1 @@
 num_ticks = 1
-known_failure = true
diff --git a/tests/tests/swfs/from_avmplus/ecma3/TypeConversion/e9_7/test.toml b/tests/tests/swfs/from_avmplus/ecma3/TypeConversion/e9_7/test.toml
@@ -1,2 +1 @@
 num_ticks = 1
-known_failure = true