Fix: #652: Resolve flake8 complaints #653
Conversation
| # F401 skipped (imported but unused) after verifying current usage is valid | ||
| # W503 skipped line break before binary operator | ||
| # C901 skipped: 'MLaunchTool.init' is too complex | ||
| ignore = E123,E125,N802,N806,F401,W503,C901 |
There was a problem hiding this comment.
An alternative to ignoring C901 is to set max-complexity = 55 below. Possibly a minor benefit in that it will flag a change that would raise the complexity even higher. Ideally, we would do some refactoring in the future to reduce the complexity of MLaunchTool.init, since it is twice as complex as the next most complex function (MLogFilterTool.run = 27). It is a low priority though, and it is fine to just ignore that test for now.
There was a problem hiding this comment.
MLaunchTool.init should ideally be refactored in future, but given there weren't any other methods approaching this complexity I didn't think there was benefit in keeping the rule enabled.
| builtins = _ | ||
| exclude=.venv,.git,.tox,dist,*lib/python*,*egg,*figures/*,__init__.py | ||
| exclude=.venv,.git,.tox,dist,*lib/python*,*egg,*figures/*,__init__.py,build/*,setup.py,mtools/util/*,mtools/test/test_* |
There was a problem hiding this comment.
Do we want to ignore testing for mtools/util/*? Perhaps exclude for now, but raise an issue to fix violations at some point in the future?
There was a problem hiding this comment.
Ignoring for now, but will re-add in future via #655.
Description of changes
Tidy up per
tox -e flake8Testing
Ensure all tests passing on flake8, py27, and py36 envs
O/S testing: