Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference in config #391

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix reference in config #391

wants to merge 1 commit into from

Conversation

maxnoe
Copy link
Contributor

@maxnoe maxnoe commented Nov 20, 2024

Referred to itself instead of the other config variable

@maxnoe
Copy link
Contributor Author

maxnoe commented Nov 20, 2024

However, checking the code, it seems this is not uses consistently.

lib/rucio/core/permission/__init__.py has in fact complex logic to determine the policy, but in several places in the code, a simple config_get("policy", "permission") is done instead.

@maxnoe
Copy link
Contributor Author

maxnoe commented Nov 20, 2024

❯ rg -F "config_get('policy', 'permission'"
lib/rucio/transfertool/fts3.py
1370:                policy = config_get('policy', 'permission')

lib/rucio/core/permission/__init__.py
49:            FALLBACK_POLICY = config.config_get('policy', 'permission')
93:                POLICY = config.config_get('policy', 'permission')

lib/rucio/common/policy.py
35:            policy = config_get('policy', 'permission')

lib/rucio/web/ui/flask/bp.py
24:POLICY = config_get('policy', 'permission')

lib/rucio/web/ui/flask/common/utils.py
239:    policy = config_get('policy', 'permission')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant