Add support for Rails 8.0 #572
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenillen
commented
Dec 5, 2024
chenillen
commented
- add support to 8.0
- add a test all file for 6.1 - 8.0 version
| @@ -0,0 +1 @@ | |||
| 3.2.0 | |||
There was a problem hiding this comment.
not sure why we need this file, especially with .0 ...
| @@ -1,7 +1,7 @@ | |||
| require 'active_record' unless defined? ActiveRecord | |||
|
|
|||
| if [ActiveRecord::VERSION::MAJOR, ActiveRecord::VERSION::MINOR] == [5, 2] || | |||
| ActiveRecord::VERSION::MAJOR > 5 | |||
| ActiveRecord::VERSION::MAJOR >= 6 | |||
| require 'paranoia/active_record_5_2' | |||
There was a problem hiding this comment.
looking at this change, this looks badly named... do we need this patch for rails 6, 7 and 8 ?
| @@ -20,7 +21,7 @@ if RUBY_ENGINE == 'rbx' | |||
| end | |||
| end | |||
|
|
|||
| rails = ENV['RAILS'] || '~> 6.0.4' | |||
| rails = ENV['RAILS'] || '~> 6.1.0' | |||
There was a problem hiding this comment.
we could move up the rails initialization, before sqlite and use the var instead, but I can see how its equivalent. so maybe its OK as-is
There was a problem hiding this comment.
These looks like good changes... I only have minor comments... but the title is miss-leading. this isn't adding support for Rails 8. it's only fixing small things and adding a script. Support for 8 is already merged in #563
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.