Fix: upsert all to not restore soft-deleted record accidentally #569
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing this issue:
When upsert records with
upsert_all
method on AR 7.0 above, Paranoia restore any matching deleted record.The sql from AR 6 returned something like this if we do an upsert from the added test:
With AR 7, InsertAll includes scope keys automatically, generates sql into something like this:
This PR excludes the paranoia_columns on conflict handling so that the paranoia column will not be replaced by NULL on upsert_all, result:
I have tested this PR in ruby 3.2.1 in rails 7.1.3.2 and 6.0.6.1.