Perf: Refactor ProductDrive#index with service #4845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't resolve any ticket.
Description
The product drives index page was mentioned to be slow in production.
Turns out it we were running two aggregate queries for every product drive (for the item quantity and number of unique items).
So listing 10 product drives meant 20 queries just to calculate the totals.
Also this page isn't paginated, so that makes the issue worse. (Although it looks like it used to be?)
Type of change
How Has This Been Tested?
Passes test suite and tested locally.
Screenshots
The performance beforehand scales linearly with number of product drives, so the more i add the worse it got.
These screenshots are when ~10 product drives were being returned.
Before:
After: