Rename default pet task to checklist task template #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ErinClaudio
force-pushed
the
Rename-DefaultPetTask-to-ChecklistTaskTemplate
branch
2 times, most recently
from
d2cdc9d to
970335e
Compare
kasugaijin
reviewed
Jun 27, 2024
* add: authenticate_user! as a before action in application controller instead of calling it within multiple controllers * add: skip_before_action authenticate_user! for controllers that don't need user authentication * remove: commented out 'skip_before_action' from controllers * fix failing tests: after adding authentication * add: config for devise configuration for setting up custom failures through warden in the devise.rb * add custom failure file * update: failure app Co-authored-by: Paul DobbinSchmaltz <[email protected]> * add more context to why this authentication failure app is needed. * update: rails standard fix
ErinClaudio
force-pushed
the
Rename-DefaultPetTask-to-ChecklistTaskTemplate
branch
from
7d72b16 to
46cf248
Compare
* add: authenticate_user! as a before action in application controller instead of calling it within multiple controllers * add: skip_before_action authenticate_user! for controllers that don't need user authentication * remove: commented out 'skip_before_action' from controllers * fix failing tests: after adding authentication * add: config for devise configuration for setting up custom failures through warden in the devise.rb * add custom failure file * update: failure app Co-authored-by: Paul DobbinSchmaltz <[email protected]> * add more context to why this authentication failure app is needed. * update: rails standard fix
* add: authenticate_user! as a before action in application controller instead of calling it within multiple controllers * add: skip_before_action authenticate_user! for controllers that don't need user authentication * remove: commented out 'skip_before_action' from controllers * fix failing tests: after adding authentication * add: config for devise * add custom failure file * update: failure app Co-authored-by: Paul DobbinSchmaltz <[email protected]> * add more context to why this authentication failure app is needed. * update: rails standard fix Update with failures but no errors
zanetagebka
reviewed
Jul 12, 2024
| @@ -1,4 +1,4 @@ | |||
| class CreatePageTexts < ActiveRecord::Migration[7.0] | |||
| class CreateCustomPages < ActiveRecord::Migration[7.0] | |||
There was a problem hiding this comment.
Why class name is different than file name? I am not sure if this is good way to go
There was a problem hiding this comment.
Yes it should be the same. This was fixed in main branch a few days ago as it was an error.
|
@ErinClaudio the errors look like they are related to an issue in main branch a few days ago related to the rename of page texts to custom pages. I pushed a fix to main. There were three migrations renamed incorrectly, each to do with page texts. 7947be3 I’d start there to make sure these changes are reflected in this PR |
* add: authenticate_user! as a before action in application controller instead of calling it within multiple controllers * add: skip_before_action authenticate_user! for controllers that don't need user authentication * remove: commented out 'skip_before_action' from controllers * fix failing tests: after adding authentication * add: config for devise configuration for setting up custom failures through warden in the devise.rb * add custom failure file * update: failure app Co-authored-by: Paul DobbinSchmaltz <[email protected]> * add more context to why this authentication failure app is needed. * update: rails standard fix
* add: authenticate_user! as a before action in application controller instead of calling it within multiple controllers * add: skip_before_action authenticate_user! for controllers that don't need user authentication * remove: commented out 'skip_before_action' from controllers * fix failing tests: after adding authentication * add: config for devise configuration for setting up custom failures through warden in the devise.rb * add custom failure file * update: failure app Co-authored-by: Paul DobbinSchmaltz <[email protected]> * add more context to why this authentication failure app is needed. * update: rails standard fix
* add: authenticate_user! as a before action in application controller instead of calling it within multiple controllers * add: skip_before_action authenticate_user! for controllers that don't need user authentication * remove: commented out 'skip_before_action' from controllers * fix failing tests: after adding authentication * add: config for devise * add custom failure file * update: failure app Co-authored-by: Paul DobbinSchmaltz <[email protected]> * add more context to why this authentication failure app is needed. * update: rails standard fix Update with failures but no errors
|
Comment for tracking purposes - I have discussed with @ErinClaudio and we will go to MVP with the default pet task architecture and can take our time to build out the Checklist::TaskTemplate, Checklist::TaskItem and Checklist::TaskAssignments from this PR/branch Tagging @jmilljr24 @mononoken for visibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue
(#834)
✍️ Description
📷 Screenshots/Demos