[work in progress] External Form Upload: Display import summary / errors #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmilljr24
reviewed
Dec 5, 2024
| @@ -13,6 +13,7 @@ def initialize(file) | |||
| end | |||
|
|
|||
| def call | |||
| # Validate that file is in CSV format before we read from it. | |||
There was a problem hiding this comment.
@khiga8 Thanks for pointing this out! This started a discussion in our last meeting about other validations we should be checking for in this service. I opened PR #1211 which adds a file type validation and checks for the correct headers.
Hopefully I didn't step on your toes, but I figured the validations were outside the scope of this issues and didn't want to cause any confusion or add more work. If you have a better way to validate though I'd love to see it!!
There was a problem hiding this comment.
This is great! Thank you :)
khiga8
force-pushed
the
kh-handle-form
branch
from
75f55ce to
07378f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue
#1112
✍️ Description
📷 Screenshots/Demos