Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak/sponsor logos displayed on welcome page #214

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

cnandes
Copy link
Contributor

@cnandes cnandes commented Oct 31, 2023

Sponsor logos added to welcome/home page and link through to corresponding show pages. Makes sponsor information visible without the need to click through to "/sponsorship" page.

image

@cnandes cnandes requested a review from Cueball October 31, 2023 13:05
@Cueball
Copy link
Contributor

Cueball commented Oct 31, 2023

Wow; I'm a bit stunned because I didn't expect this right now - and legit almost exactly what I'd pictured. Kudos 🙌

Two tweaks I'd suggest:

  • Make the Up logo a tad larger? I know I spent quite a bit of time (back in January?) trying to balance their odd logo shape to not make it appear smaller than other logos.
    • If it's troublesome, leave it.
  • For the first four (our "Major Sponsors", AssemblyFour through Buildkite) - can we make those logos larger/more prominent?
    • Again - IIRC? there's some janky layout code for the sponsor logos that means all the logos need to be the same size (or that might be the conf website, IDK?).

So if it's more than a few minutes work, leave it be and we can revisit the logo size issue in the future - not obligated to have logos on the RubyAU home page at all, so there's that 🙃. Otherwise, that's great work!

@leesheppard
Copy link
Member

@cnandes can you share a screenshot of the mobile view of this layout?

@cnandes
Copy link
Contributor Author

cnandes commented Dec 11, 2023

I've just pushed additional changes to better centre the logos for mobile and enlarge the up logo, but alas I will need to better look into those build failures at another time 🦇

image

@leesheppard leesheppard merged commit 09386bb into main Dec 11, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants