130 - fix rubocop issues

.rubocop.yml

@@ -25,6 +25,7 @@ Metrics/ModuleLength:
 Metrics/BlockLength:
   Exclude:
     - 'spec/**/*'
+    - 'config/routes.rb'
 
 # Allow both single-quoted and double-quoted string literals.
 Style/StringLiterals:

app/controllers/my/emails_controller.rb

@@ -15,7 +15,7 @@ def create
   def set_primary
     email = Email.find(params[:id])
     ActiveRecord::Base.transaction do
-      current_user.emails.where(primary: true).update_all(primary: false)
+      current_user.emails.where(primary: true).find_each { |email| email.update!(primary: false) }
       email.update!(primary: true)
     end
 

app/models/email.rb

@@ -1,4 +1,4 @@
-class Email < ActiveRecord::Base
+class Email < ApplicationRecord
   belongs_to :user
 
   validates :email, presence: true, uniqueness: true

app/models/user.rb

@@ -23,7 +23,7 @@ class User < ApplicationRecord
     )
   }
   scope :committee, -> { where(committee: true) }
-  scope :without_emails, -> {
+  scope :without_emails, lambda {
     left_outer_joins(:emails)
       .where(emails: { id: nil })
       .where.not(email: nil)

spec/factories/email.rb

@@ -4,7 +4,7 @@
     email { Faker::Internet.email }
 
     trait :confirmed do
-      confirmed_at { Time.now }
+      confirmed_at { Time.current }
     end
   end
 end

spec/models/email_spec.rb

@@ -27,7 +27,7 @@
 
     context 'uniqueness' do
       it 'requires a unique email address regardless of case' do
-        existing_email = create(:email, email: '[email protected]')
+        create(:email, email: '[email protected]')
         new_email = build(:email, email: '[email protected]')
 
         expect(new_email).not_to be_valid

spec/requests/imported_members_spec.rb

@@ -12,9 +12,9 @@
 
     context "with valid parameters" do
       it "creates new imported members" do
-        expect {
+        expect do
           post admin_imported_members_path, params: { source: source, file: file }
-        }.to change(ImportedMember, :count).by(2)
+        end.to change(ImportedMember, :count).by(2)
 
         expect(response).to redirect_to(admin_imported_members_path)
         follow_redirect!
@@ -45,9 +45,9 @@
       it "updates the existing imported member" do
         existing_member = create(:imported_member, email: '[email protected]', full_name: 'Old Name', data: { sources: ['old_source'] })
 
-        expect {
+        expect do
           post admin_imported_members_path, params: { source: source, file: file }
-        }.to change(ImportedMember, :count).by(1)
+        end.to change(ImportedMember, :count).by(1)
 
         existing_member.reload
         expect(existing_member.full_name).to eq('Old Name')
@@ -59,9 +59,9 @@
       it "skips the row" do
         create(:email, email: '[email protected]')
 
-        expect {
+        expect do
           post admin_imported_members_path, params: { source: source, file: file }
-        }.to change(ImportedMember, :count).by(1)
+        end.to change(ImportedMember, :count).by(1)
 
         expect(ImportedMember.find_by(email: '[email protected]')).to be_nil
       end
@@ -71,9 +71,9 @@
       let(:file) { fixture_file_upload('imported_members_blank_email.csv', 'text/csv') }
 
       it "skips the row" do
-        expect {
+        expect do
           post admin_imported_members_path, params: { source: source, file: file }
-        }.to change(ImportedMember, :count).by(1)
+        end.to change(ImportedMember, :count).by(1)
 
         expect(ImportedMember.find_by(email: '')).to be_nil
       end

spec/requests/invitations_spec.rb

@@ -19,7 +19,6 @@
 
         post "/invitations/#{imported_member.token}", params: { user: user_params }
 
-
         expect(response).to redirect_to(root_path)
         expect(flash[:notice]).to eq("Your membership to Ruby Australia has been confirmed.")
         user = User.last
@@ -32,7 +31,7 @@
     end
 
     context "with invalid user params" do
-       let(:user_params) { { full_name: "", email: imported_member.email, password: "password", password_confirmation: "wrong_password" } }
+      let(:user_params) { { full_name: "", email: imported_member.email, password: "password", password_confirmation: "wrong_password" } }
 
       it "renders the new template" do
         post "/invitations/#{imported_member.token}", params: { user: user_params }

spec/requests/mailing_lists_spec.rb

@@ -15,7 +15,7 @@
               "Type" => "Subscribe",
               "EmailAddress" => user.email,
               "ListId" => list.api_id,
-            },
+            }
           ],
         }.to_json
       end
@@ -36,7 +36,7 @@
               "Type" => "Deactivate",
               "EmailAddress" => user.email,
               "ListId" => list.api_id,
-            },
+            }
           ],
         }.to_json
       end
@@ -72,7 +72,7 @@
               "Type" => "Subscribe",
               "EmailAddress" => "[email protected]",
               "ListId" => list.api_id,
-            },
+            }
           ],
         }.to_json
       end

spec/requests/my/emails_spec.rb

@@ -17,18 +17,18 @@
   describe "POST /create" do
     context "with valid parameters" do
       it "creates a new email and redirects to my_details_path" do
-        expect {
+        expect do
           post my_emails_path, params: { email: { email: "[email protected]" } }
-        }.to change(Email, :count).by(1)
+        end.to change(Email, :count).by(1)
         expect(response).to redirect_to(my_details_path)
       end
     end
 
     context "with invalid parameters" do
       it "re-renders the new template" do
-        expect {
+        expect do
           post my_emails_path, params: { email: { email: "" } }
-        }.not_to change(Email, :count)
+        end.not_to change(Email, :count)
         expect(response).to render_template(:new)
       end
     end
@@ -51,9 +51,9 @@
     let!(:email) { create(:email, user: user) }
 
     it "deletes the specified email and redirects to my_details_path" do
-      expect {
+      expect do
         delete my_email_path(email)
-      }.to change(Email, :count).by(-1)
+      end.to change(Email, :count).by(-1)
       expect(response).to redirect_to(my_details_path)
     end
   end

spec/requests/reactivations_spec.rb

@@ -29,9 +29,9 @@
       end
 
       it "does not create a new membership" do
-        expect {
+        expect do
           post "/reactivations", params: { user: { email: user.email, password: "wrong_password" } }
-        }.not_to change(Membership, :count)
+        end.not_to change(Membership, :count)
       end
 
       it "does not sign in the user" do