Drop dependency on abbrev
#1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulling in something extra just for this seems pretty wasteful
ParadoxV5
reviewed
Jun 5, 2024
| case subcommand | ||
| when 'install' | ||
| case args[0] | ||
| when 'install', 'instal', 'insta', 'inst', 'ins', 'in', 'i' |
There was a problem hiding this comment.
'install'.start_with? args[0]? ε:
|
I'm open to this change. It implements the same feature after dropping |
|
No real problem, I just like having a small dependency tree if possible. Abbrev isn't buildin anymore, if it did something more complicated there could be an argument for it but it really isn't doing much as it is used here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling in something extra just for this seems pretty wasteful in my opinion