Remove non-ASCII source characters #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Nov 20, 2023
This was referenced Nov 21, 2023
nobu
reviewed
Nov 24, 2023
Comment on lines
+378
to
+379
| # Enforce that we only have ASCII characters here. This is necessary | ||
| # for some locales that only allow ASCII characters in C source files. |
There was a problem hiding this comment.
This comment is not exact.
Maybe "other than UTF-8 locales"?
There was a problem hiding this comment.
That makes sense! I'll update it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.