Fix parsing while and until
#1773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddnewton
requested changes
Nov 9, 2023
| @@ -14636,7 +14636,7 @@ parse_expression_prefix(pm_parser_t *parser, pm_binding_power_t binding_power) { | |||
| parser_lex(parser); | |||
| pm_token_t keyword = parser->previous; | |||
|
|
|||
| pm_node_t *predicate = parse_expression(parser, PM_BINDING_POWER_COMPOSITION, PM_ERR_CONDITIONAL_UNTIL_PREDICATE); | |||
| pm_node_t *predicate = parse_expression(parser, PM_BINDING_POWER_MODIFIER, PM_ERR_CONDITIONAL_UNTIL_PREDICATE); | |||
There was a problem hiding this comment.
I think this won't be quite right because it's going to allow:
while foo if bar; endThis is a bigger problem in that we don't have a delineation between statements and expressions (it's a different issue).
I think maybe we could solve this just for now by splitting up the precedence between in and the other modifiers to make in a higher precedence.
makenowjust
added a commit
to makenowjust/prism-1
that referenced
this pull request
Nov 11, 2023
makenowjust
added a commit
to makenowjust/prism-1
that referenced
this pull request
Nov 11, 2023
makenowjust
added a commit
to makenowjust/prism-1
that referenced
this pull request
Nov 11, 2023
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1771