Some constant pool fixes and enhancements #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eregon
reviewed
Oct 18, 2023
| static const pm_constant_pool_bucket_type_t PM_CONSTANT_POOL_BUCKET_OWNED = 1; | ||
|
|
||
| // A constant constant is known at compile time. | ||
| static const pm_constant_pool_bucket_type_t PM_CONSTANT_POOL_BUCKET_CONSTANT = 2; |
There was a problem hiding this comment.
Would an enum work here? Or C doesn't like the pm_constant_pool_bucket_type_t type: 2; below with an enum type?
There was a problem hiding this comment.
I believe bit fields can only be unsigned ints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pm_string_t, meaning it allocated memory even if the value was known at compile time. This has been fixed....is present in a method definition, you can use*and&to forward subsets of all of the parameters. This has been fixed.Debugmodule worked when comparing locals in the locals test. This makes it much more obvious where we need anonymous locals to handle specific values.