Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add me to reviewer for couple of rails dependent gems #584

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Add me to reviewer for couple of rails dependent gems #584

merged 1 commit into from
Jun 5, 2024

Conversation

ydah
Copy link
Member

@ydah ydah commented Jun 4, 2024

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

@ydah Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

actionmailer

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@ksss, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.

actionview

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@ksss, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.

activesupport

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@hibariya, @ksss, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.

hibariya
hibariya reviewed Jun 4, 2024
View reviewed changes
Copy link
Contributor

@hibariya hibariya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

APPROVE

@hibariya
Copy link
Contributor

hibariya commented Jun 4, 2024

/merge

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

/merge command failed.

This PR is not approved yet by the reviewers. Please get approval from the reviewers.
See the Actions tab for detail.

@ksss
Copy link
Collaborator

ksss commented Jun 5, 2024

APPROVE 👍

@ksss
Copy link
Collaborator

ksss commented Jun 5, 2024

/merge

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

/merge command failed.

This PR is not approved yet by the reviewers. Please get approval from the reviewers.
See the Actions tab for detail.

ksss
ksss reviewed Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@ksss ksss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE 👍 👍 👍

@ksss
Copy link
Collaborator

ksss commented Jun 5, 2024

/merge

@github-actions github-actions bot merged commit e82325e into ruby:main Jun 5, 2024
6 checks passed
@ydah ydah deleted the addme branch June 5, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksss ksss ksss left review comments

@hibariya hibariya hibariya left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ydah @hibariya @ksss