Export data from all number systems #189
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fixes #89
Fixes #167
ruby-cldr
was outputting number data from arbitrary number systems based on whatever data it first encountered. This resulted in the data from multiple number systems getting incorrectly mixed in the output.What approach did you choose and why?
This is a large refactor/overhaul of the existing
Numbers
component.It adds the number system as a new level of nesting in the output, and changes the key structure to more closely match the structure and terminology of the upstream CLDR data.
The
Numbers
component now outputs the number data for all number systems.What should reviewers focus on?
...
The impact of these changes
This is a breaking change for downstream consumers, since the key structure of the output
numbers.yml
files has changed significantly with this PR:number_system
key has been removed; the keys are now nested under the number systemstandard
subtype (meaning that other subtypes are now able to be exported. e.g.,accounting
)Testing
...
Checklist