remove unnecessary changes due to the refactor in opensearch-project#…

…6234 (#331) * remove unnecessary changes due to the refactor in 6234 Signed-off-by: Yulong Ruan <[email protected]> * fix snapshot Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]>
ruanyl · Apr 17, 2024 · 4ea9ea1 · 4ea9ea1
1 parent 32fab61
commit 4ea9ea1
Show file tree

Hide file tree

Showing 7 changed files with 3 additions and 33 deletions.
diff --git a/src/core/public/chrome/chrome_service.mock.ts b/src/core/public/chrome/chrome_service.mock.ts
@@ -44,7 +44,6 @@ const createStartContractMock = () => {
     getHeaderComponent: jest.fn(),
     navLinks: {
       getNavLinks$: jest.fn(),
-      getLinkUpdaters$: jest.fn(),
       has: jest.fn(),
       get: jest.fn(),
       getAll: jest.fn(),

diff --git a/src/core/public/chrome/index.ts b/src/core/public/chrome/index.ts
@@ -45,12 +45,7 @@ export {
   ChromeHelpExtensionMenuGitHubLink,
 } from './ui/header/header_help_menu';
 export { NavType } from './ui';
-export {
-  ChromeNavLink,
-  ChromeNavLinks,
-  ChromeNavLinkUpdateableFields,
-  LinksUpdater,
-} from './nav_links';
+export { ChromeNavLink, ChromeNavLinks, ChromeNavLinkUpdateableFields } from './nav_links';
 export { ChromeRecentlyAccessed, ChromeRecentlyAccessedHistoryItem } from './recently_accessed';
 export { ChromeNavControl, ChromeNavControls } from './nav_controls';
 export { ChromeDocTitle } from './doc_title';
diff --git a/src/core/public/chrome/nav_links/index.ts b/src/core/public/chrome/nav_links/index.ts
@@ -29,4 +29,4 @@
  */
 
 export { ChromeNavLink, ChromeNavLinkUpdateableFields } from './nav_link';
-export { ChromeNavLinks, NavLinksService, LinksUpdater } from './nav_links_service';
+export { ChromeNavLinks, NavLinksService } from './nav_links_service';
diff --git a/src/core/public/chrome/nav_links/nav_links_service.ts b/src/core/public/chrome/nav_links/nav_links_service.ts
@@ -53,13 +53,6 @@ export interface ChromeNavLinks {
    */
   getNavLinks$(): Observable<Array<Readonly<ChromeNavLink>>>;
 
-  /**
-   * Get an observable for the current link updaters. Link updater is used to modify the
-   * nav links, for example, filter the nav links or update a specific nav link's properties.
-   * {@link LinksUpdater}
-   */
-  getLinkUpdaters$(): BehaviorSubject<LinksUpdater[]>;
-
   /**
    * Get the state of a navlink at this point in time.
    * @param id
@@ -119,7 +112,7 @@ export interface ChromeNavLinks {
   getForceAppSwitcherNavigation$(): Observable<boolean>;
 }
 
-export type LinksUpdater = (navLinks: Map<string, NavLinkWrapper>) => Map<string, NavLinkWrapper>;
+type LinksUpdater = (navLinks: Map<string, NavLinkWrapper>) => Map<string, NavLinkWrapper>;
 
 export class NavLinksService {
   private readonly stop$ = new ReplaySubject(1);
@@ -158,10 +151,6 @@ export class NavLinksService {
         return navLinks$.pipe(map(sortNavLinks), takeUntil(this.stop$));
       },
 
-      getLinkUpdaters$: () => {
-        return linkUpdaters$;
-      },
-
       get(id: string) {
         const link = navLinks$.value.get(id);
         return link && link.properties;

diff --git a/src/core/public/index.ts b/src/core/public/index.ts
@@ -67,7 +67,6 @@ import {
   ChromeStart,
   ChromeRecentlyAccessed,
   ChromeRecentlyAccessedHistoryItem,
-  LinksUpdater,
   NavType,
 } from './chrome';
 import { FatalErrorsSetup, FatalErrorsStart, FatalErrorInfo } from './fatal_errors';
@@ -326,7 +325,6 @@ export {
   ChromeRecentlyAccessed,
   ChromeRecentlyAccessedHistoryItem,
   ChromeStart,
-  LinksUpdater,
   IContextContainer,
   HandlerFunction,
   HandlerContextType,

diff --git a/...ic/application/components/dashboard_listing/__snapshots__/dashboard_listing.test.tsx.snap b/...ic/application/components/dashboard_listing/__snapshots__/dashboard_listing.test.tsx.snap
diff --git a/...ic/application/components/dashboard_top_nav/__snapshots__/dashboard_top_nav.test.tsx.snap b/...ic/application/components/dashboard_top_nav/__snapshots__/dashboard_top_nav.test.tsx.snap