Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Purge for AMP URL when a Post or Page is Published. #353

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Add Purge for AMP URL when a Post or Page is Published. #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
914dccf
feat: add purging for amp urls.
Vedant-Gandhi Sep 6, 2024
c2a1416
refactor: fix indentation.
Vedant-Gandhi Sep 6, 2024
6048861
refactor: added sprintf instead of concatenating string when generati…
Vedant-Gandhi Oct 17, 2024
b34d004
Merge branch 'develop' into feat/add-amp-url-purge
Vedant-Gandhi Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions admin/class-fastcgi-purger.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,29 @@ public function purge_url( $url, $feed = true ) {
break;

}

if( ( is_page() || is_single() ) && $nginx_helper_admin->options['purge_amp_urls'] ) {
$this->purge_amp_version( $url );
}

}

/**
* Purge AMP version of a URL.
*
* @param string $url_base The base URL to purge.
*/
private function purge_amp_version( $url_base ) {
$amp_url = sprintf( '%s/amp/', rtrim( $url_base, '/' ) );

$this->log('- Purging AMP URL | ' . $amp_url);

if ( 'unlink_files' === $this->nginx_helper_admin->options['purge_method'] ) {
$this->delete_cache_file_for( $amp_url );
} else {
$this->do_remote_get( $amp_url );
}
}

/**
* Function to custom purge urls.
Expand Down
1 change: 1 addition & 0 deletions admin/class-nginx-helper-admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ public function nginx_helper_default_settings() {
'redis_prefix' => 'nginx-cache:',
'purge_url' => '',
'redis_enabled_by_constant' => 0,
'purge_amp_urls' => 1,
'preload_cache' => 0,
'is_cache_preloaded' => 0
);
Expand Down
33 changes: 33 additions & 0 deletions admin/partials/nginx-helper-general-options.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
'purge_page_on_deleted_comment',
'purge_feeds',
'smart_http_expire_form_nonce',
'purge_amp_urls',
'preload_cache',
);

Expand Down Expand Up @@ -555,6 +556,38 @@
</td>
</tr>
</table>
<table class="form-table rtnginx-table">
<tr valign="top">
<th scope="row">
<h4>
<?php esc_html_e( 'Purge AMP URL:', 'nginx-helper' ); ?>
</h4>
</th>
<td>
<fieldset>
<legend class="screen-reader-text">
<span>
&nbsp;
<?php
esc_html_e( 'purge amp urls', 'nginx-helper' );
?>
</span>
</legend>
<label for="purge_amp_urls">
<input type="checkbox" value="1" id="purge_amp_urls" name="purge_amp_urls" <?php checked( $nginx_helper_settings['purge_amp_urls'], 1 ); ?> />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this option enabled by default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SH4LIN I have enabled it in accordance with the default behaviour since, by default, all other options—aside from comments—are enabled when purge is enabled.

&nbsp;
<?php
echo wp_kses(
__( 'purge <strong>amp urls</strong> along with <strong>posts</strong> & <strong>pages</strong>.', 'nginx-helper' ),
array( 'strong' => array() )
);
?>
</label>
<br />
</fieldset>
</td>
</tr>
</table>
<table class="form-table rtnginx-table">
<tr valign="top">
<th scope="row">
Expand Down
Loading